Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store information about execution failure timing #15285

Merged

Conversation

krassowski
Copy link
Member

References

deshaw/jupyterlab-execute-time#84

Code changes

Adds execution_failed to execution metadata when execution is aborted due to kernel restart/when kernel dies.

Questions:

  • is execution_failed the best name? the other existing keys are derived from message channel/name/status:
    const TIMING_KEYS = [
    'iopub.execute_input',
    'shell.execute_reply.started',
    'shell.execute_reply',
    'iopub.status.busy',
    'iopub.status.idle'
    ];

User-facing changes

Users of jupyterlab-execute-time will be able to see when the execution failed/after how much time rather than incorrectly seeing the execution timer continue.

Before After
execute-before execute-after

Backwards-incompatible changes

None

@krassowski krassowski added this to the 4.1.0 milestone Oct 21, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@krassowski krassowski merged commit 238af0a into jupyterlab:main Oct 29, 2023
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants