Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport disabling custom keyboard JS in html docs #15304

Closed
wants to merge 1 commit into from
Closed

backport disabling custom keyboard JS in html docs #15304

wants to merge 1 commit into from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 25, 2023 •
edited by krassowski

References

Fixes #15309

Code changes

  • docs
    • disable custom JS keyboard navigation in pydata-sphinx-theme (also raises warning)

User-facing changes

Users of the documentation website will have their expected keyboard shortcuts for arrow keys instead of custom ones.

Backwards-incompatible changes

  • n/a

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@bollwyvl bollwyvl mentioned this pull request Oct 25, 2023
Merged
9 tasks
@krassowski krassowski added this to the 4.0.x milestone Oct 25, 2023
@krassowski krassowski mentioned this pull request Oct 26, 2023
Closed
@fcollonval
Copy link
Member

Sorry @bollwyvl I missed this PR - closing as duplicate of #15310

@fcollonval fcollonval closed this Oct 26, 2023
@bollwyvl bollwyvl deleted the gh-15302-docs-native-keyboard branch October 26, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bollwyvl bollwyvl

Labels
documentation
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bollwyvl @fcollonval @krassowski