Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs deployment failing on 3.6 branch #15424

Merged
merged 6 commits into from Dec 11, 2023

Conversation

krassowski
Copy link
Member

References

Failure:

Problem in your project's configuration. Invalid configuration option "build.os": build not found

was seen in #15395

Code changes

Adds build.os and other relevant build config.

User-facing changes

None

Backwards-incompatible changes

None

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski changed the title Fix docs deplyment failing on 3.6 branch Fix docs deployment failing on 3.6 branch Nov 17, 2023
@krassowski krassowski added this to the 3.6.x milestone Nov 17, 2023
@krassowski
Copy link
Member Author

It now fails later on with a different traceback:

python -mvirtualenv $READTHEDOCS_VIRTUALENV_PATH
usage: virtualenv [--version] [--with-traceback] [-v | -q] [--read-only-app-data] [--app-data APP_DATA] [--reset-app-data] [--upgrade-embed-wheels] [--discovery {builtin}] [-p py] [--try-first-with py_exe]
                  [--creator {builtin,cpython3-posix,venv}] [--seeder {app-data,pip}] [--no-seed] [--activators comma_sep_list] [--clear] [--no-vcs-ignore] [--system-site-packages] [--symlinks | --copies] [--no-download | --download]
                  [--extra-search-dir d [d ...]] [--pip version] [--setuptools version] [--wheel version] [--no-pip] [--no-setuptools] [--no-wheel] [--no-periodic-update] [--symlink-app-data] [--prompt prompt] [-h]
                  dest
SystemExit: 2
virtualenv: error: the following arguments are required: dest

Bumping python version did not solve it.

@krassowski
Copy link
Member Author

All right, this works:

Screenshot from 2023-12-09 17-51-02
Screenshot from 2023-12-09 17-51-24

@krassowski krassowski marked this pull request as ready for review December 9, 2023 17:58
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit d68fca2 into jupyterlab:3.6.x Dec 11, 2023
67 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants