Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hatchling #15694

Merged
merged 1 commit into from Jan 26, 2024
Merged

Bump hatchling #15694

merged 1 commit into from Jan 26, 2024

Conversation

fcollonval
Copy link
Member

References

Fixes #15692

Code changes

Bump hatchling to include the fix for importlib.util import error

User-facing changes

None

Backwards-incompatible changes

None

Bump hatchling to include the fix for `importlib.util` import error
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski
Copy link
Member

So this is going from 1.5.0 to 1.21.1, two relevant changes in the changelog:

  • 1.18.0 dropped support for Python 3.7
  • 1.19.0 added official support for Python 3.12 (though my reading is that it already worked before)

I think this is fine for the main and 4.0.x; not sure about backporting to 3.6.x though.

@krassowski krassowski added this to the 4.0.x milestone Jan 25, 2024
@fcollonval
Copy link
Member Author

not sure about backporting to 3.6.x though.

It is fine as we are using jupyter-packaging for 3.6:

requires=["jupyter_packaging>=0.9,<2"]

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@krassowski krassowski merged commit 85445cc into main Jan 26, 2024
77 of 79 checks passed
@krassowski krassowski deleted the fcollonval-patch-1 branch January 26, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ci failing across jobs on installation step
2 participants