Fix cell toolbar getting stuck when using collapse cell #15732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
@meeseeksdev tag bug |
krassowski
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Thank you @FoSuCloud!
Minor suggestion on the style of the comment.
thank you for the change |
krassowski
changed the title
|
@meeseeksdev please backport to 4.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Feb 3, 2024
…ng collapse cell
krassowski
pushed a commit
that referenced
this pull request
Feb 3, 2024
…e cell (#15738) Co-authored-by: FoSuCloud <49218295+FoSuCloud@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #15671
Code changes
The reason for the bug is that after the folded cell is clicked, the
_onActiveCellChangedfunction is triggered, but because theinputHiddenattribute of the folded cell activeCell is true, the_previousActiveCellvariable is not updated.After that, clicking other cells cannot destroy the previous active cell toolbar
User-facing changes
Before the change
false.mp4
After the change
true.mp4
Backwards-incompatible changes
nothing