Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long items should not wrap #15844

Merged
merged 3 commits into from Mar 21, 2024
Merged

Long items should not wrap #15844

merged 3 commits into from Mar 21, 2024

Conversation

mdietz94
Copy link
Contributor

If they wrap, it causes the text to overlap with the text on the next line, and can happen for instance if tab completing directories that contain a hyphen.

If they wrap, it causes the text to overlap with the text on the next line, and can happen for instance if tab completing directories that contain a hyphen.
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link

welcome bot commented Feb 21, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions github-actions bot added pkg:completer tag:CSS For general CSS related issues and pecadilloes Design System CSS labels Feb 21, 2024
@krassowski
Copy link
Member

@mdietz94 can you provide before and after screenshots? Could you also see if this was reported in any issue before and if so link the PR to an issue?

@krassowski krassowski added the bug label Feb 22, 2024
@mdietz94
Copy link
Contributor Author

Attached are pictures from before (with wrapping) and after my fix. I could not find any open issues that were related to this problem (though I could create one if you need).

@mdietz94
Copy link
Contributor Author

image

@mdietz94
Copy link
Contributor Author

image

@mdietz94
Copy link
Contributor Author

The bottom picture is before and the top picture was after my fix. As you can see post fix you can actually tell what is being completed. Sorry for all the comments I was having trouble uploading the images.

Thanks!

@krassowski krassowski added this to the 4.1.x milestone Mar 4, 2024
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mdietz94!

@mdietz94
Copy link
Contributor Author

Thank you for the review!

@krassowski krassowski merged commit cb50196 into jupyterlab:main Mar 21, 2024
80 checks passed
Copy link

welcome bot commented Mar 21, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@krassowski
Copy link
Member

@meeseeksdev please backport to 4.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Mar 21, 2024
krassowski pushed a commit that referenced this pull request Mar 21, 2024
Co-authored-by: Max Dietz <maxwell.r.dietz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Design System CSS pkg:completer tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants