New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long items should not wrap #15844
Long items should not wrap #15844
Conversation
If they wrap, it causes the text to overlap with the text on the next line, and can happen for instance if tab completing directories that contain a hyphen.
Thanks for making a pull request to jupyterlab! |
Thanks for submitting your first pull request! You are awesome! 🤗 |
@mdietz94 can you provide before and after screenshots? Could you also see if this was reported in any issue before and if so link the PR to an issue? |
Attached are pictures from before (with wrapping) and after my fix. I could not find any open issues that were related to this problem (though I could create one if you need). |
The bottom picture is before and the top picture was after my fix. As you can see post fix you can actually tell what is being completed. Sorry for all the comments I was having trouble uploading the images. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mdietz94!
Thank you for the review! |
@meeseeksdev please backport to 4.1.x |
Co-authored-by: Max Dietz <maxwell.r.dietz@gmail.com>
If they wrap, it causes the text to overlap with the text on the next line, and can happen for instance if tab completing directories that contain a hyphen.