Fix saving shortcut not preventing default #15913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
azurelim
reviewed
Mar 6, 2024
jtpio
reviewed
Mar 7, 2024
| ((event.ctrlKey || event.metaKey) && event.key.toLowerCase() == 's') || | ||
| // Command + Shift + C on Mac should only open the Command Palette | ||
| // (rather than also opening the Dev Tools) | ||
| (event.metaKey && event.shiftKey && event.key.toLowerCase() == 'c') |
There was a problem hiding this comment.
Should this condition also be valid on non-mac devices?
There was a problem hiding this comment.
Yes, though honestly I'm also considering just reverting this handler logic altogether until we get the the improved handling in lumino.
There was a problem hiding this comment.
Right, but I guess we'll still want this as a hot fix for now?
There was a problem hiding this comment.
No, I mean closing this one and merging revert PR #15938. This is mostly because I think we should not be breaking shortcuts contributed by extensions for which we do not have ability to provide a set of workaround like in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Ctrl + Striggle browser's "save page", not save notebook in4.1.3#15912Code changes
Immediately process keydown event for ctrl + s and on command + shift + c.
User-facing changes
Saving with ctrl + s will no longer show spurious browser dialog
Backwards-incompatible changes
None