Upgrade lumino to v2024.3.25, improve CodeMirror shortcuts handling #16078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:terminal
pkg:notebook
pkg:codeeditor
pkg:console
pkg:filebrowser
pkg:completer
pkg:docregistry
tag:Examples
pkg:inspector
pkg:launcher
pkg:application
pkg:running
pkg:fileeditor
pkg:help
pkg:csvviewer
pkg:imageviewer
pkg:markdownviewer
pkg:rendermime
pkg:tooltip
pkg:apputils
pkg:cells
pkg:codemirror
pkg:docmanager
pkg:outputarea
pkg:shortcuts
pkg:settingeditor
labels
krassowski
force-pushed
the
upgrade-lumino
branch
from
3f86f7e
to
462422e
Compare
|
This also means that Ctrl+Shift+K no longer opens Table Of Contents when in edit mode (it now only deletes the current line; previously it did both: #16096). Given the issues:
I propose that we disable these default keybindings and add proper commands for them. |
krassowski
changed the title
krassowski
force-pushed
the
upgrade-lumino
branch
from
027a0a6
to
c4d2ea6
Compare
krassowski
commented
Apr 3, 2024
|
It looks like the galata tests are failing because |
This was referenced Apr 4, 2024
krassowski
changed the title
fcollonval
reviewed
Apr 8, 2024
gderocher
pushed a commit
to gderocher/jupyterlab
that referenced
this pull request
Apr 26, 2024
…upyterlab#16078) * Upgrade lumino packages to v2024.3.25 * Add shortcuts/commands for CM, fix issues with new lumino version. * Fix escape and toggle back extending selection * Update tests for extending selection * Add tests for delete line, comment line, and comment block commands * Update help snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
preventDefaultto prevent default CodeMirror actions - instead we filter these out in the first place.⇧ ⌘ K) brings up the Table of Contents and DELETES CODE #16096; the new behaviour is to delete the line but the shortcut can now be disabled from settings if a user prefers it to always open the ToCCode changes
None
User-facing changes
Backwards-incompatible changes
None