Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating search value on input #16198

Conversation

fcollonval
Copy link
Member

References

Fixes #16193

Code changes

React to onInput event on Search react component

User-facing changes

Restore reaction on user input.

Backwards-incompatible changes

None

@fcollonval fcollonval added the bug label Apr 19, 2024
@fcollonval fcollonval added this to the 4.2.0 milestone Apr 19, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fcollonval!

@krassowski krassowski merged commit 54fe0d1 into jupyterlab:main Apr 19, 2024
83 of 84 checks passed
@fcollonval fcollonval deleted the 16193-searchfilter-boxes-do-not-update-when-typing branch April 19, 2024 10:07
gderocher pushed a commit to gderocher/jupyterlab that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search/filter boxes do not update when typing
2 participants