Ensure that input in recently open files modal is focused #16199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
commented
Apr 19, 2024
There was a problem hiding this comment.
The focus indicator is not pretty but this is out of scope for this PR.
krassowski
changed the title
gderocher
pushed a commit
to gderocher/jupyterlab
that referenced
this pull request
Apr 26, 2024
…#16199) * Add a test ensuring the modal input is focused * Await the `expect` promise * Set the focus on input inside the shadow DOM * Update snapshot which now shows the focus indicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16194
Code changes
User-facing changes
The search box in the recently closed modal gets properly focused after opening it.
Backwards-incompatible changes
None