Migrate shortcuts search to use FilterBox
#16216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes style of advanced options links, and adds missing cursor pointer styles
|
Thanks for making a pull request to jupyterlab! |
github-actions
bot
added
pkg:shortcuts
tag:CSS
|
@kolibril13 how does this one look on Binder in Safari? |
|
looks good! 
only the text overlap in the second shortcut option and "Default" remains: |
I don't know how to fix this at the moment - I would need access to Safari and right now can only run one via remote desktop which is super slow, so I would defer to someone who uses Mac to pick it up in a separate PR (though again, this looks like a Safari bug). |
|
Looks like we can still get this PR merged as an improvement, and track the remaining Safari bug in a separate issue? |
gderocher
pushed a commit
to gderocher/jupyterlab
that referenced
this pull request
Apr 26, 2024
also fixes style of advanced options links, and adds missing cursor pointer styles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16215
Code changes
FilterBoxwhich usesjupyter-ui-tookitfor search component in shortcuts UI (follow up to Use toolkit search input for all search inputs: filebrowser, extension manager, debugger kernel source #16046)jp-Shortcuts-AdvancedOptionsSmallandjp-Shortcuts-AdvancedOptionsRightstylesUser-facing changes
Filtered down, small window (see how previously "Reset All" was oddly spread across two lines - now fixed by adding
display: inline-block)Backwards-incompatible changes