Use the application name instead of hard-coded "JupyterLab" in dialogs/commands #16230
Conversation
|
Thanks for making a pull request to jupyterlab! |
| body: trans.__('Please confirm you want to shut down JupyterLab.'), | ||
| body: trans.__( | ||
| 'Please confirm you want to shut down ' + app.name + '.' | ||
| ), |
There was a problem hiding this comment.
Try to look into the rest of the codebase how translation is done. Typically you do not want to concatenate strings. For example in japanese, that would be: JupyterLab をシャットダウンすることを確認してください。 or something like that, where JupyterLab is not at the end, and the ends dot is not . but 。.
For example :
packages/notebook-extension/src/index.ts: body: trans.__('Are you sure you want to close "%1"?', fileName),
This let the translater chose where the variable goes in the translation.
If you look line 372, just above there is also a caption: trans.__('Shut down JupyterLab'),, this could also be updated.
There was a problem hiding this comment.
👍 thank you for reviewing this!
For reference: https://jupyterlab.readthedocs.io/en/stable/extension/internationalization.html
There was a problem hiding this comment.
Thank you for the feedback! Making the changes now.
krassowski
changed the title
krassowski
changed the title
|
Congrats on your first merged pull request in this project! 🎉 |
…s/commands (jupyterlab#16230) * updated shutdown dialogue to display app.name * fixed style * updated strings to conform with translation standards * style fix * Remove extra quotes --------- Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
References
jupyter/notebook#7188
"File > Shutdown in classic notebook ask if I want to shutdow JupyterLab"
Code changes
Edits shutdown dialogue body to ask if the user wants to shutdown <app.name>, instead of exclusively 'JupyterLab'
User will be prompted to confirm shutdown of Jupyter Notebook, instead of JupyterLab, when using Jupyter Notebook