Fix toggling extension at system level #16241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
|
@meeseeksdev please backport to 4.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Apr 26, 2024
krassowski
added a commit
that referenced
this pull request
Apr 26, 2024
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
gderocher
pushed a commit
to gderocher/jupyterlab
that referenced
this pull request
Apr 26, 2024
* Add a test for extension toggling the system level * Do not check higher levels for `system` level * Add sudo * Fix test * Debug CI * Try with a different extension * Use bang because `-L` does not change exit status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #16240
Code changes
_is_extension_lockedworks forsystemlevelUser-facing changes
Toggling at system level works.
Backwards-incompatible changes
None