Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Firefox from brew on Mac on CI #16245

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

krassowski
Copy link
Member

References

Fixes #16244

Code changes

Install firefox, cairo and pango from brew.

User-facing changes

None

Backwards-incompatible changes

None

@krassowski krassowski added this to the 4.0.x milestone Apr 26, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski changed the title Install firefox from brew Install Firefox from brew on Mac on CI Apr 26, 2024
@krassowski krassowski marked this pull request as ready for review April 26, 2024 10:46
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit cc35edb into jupyterlab:main Apr 26, 2024
82 of 84 checks passed
@krassowski
Copy link
Member Author

@meeseeksdev please backport to 4.1.x
@meeseeksdev please backport to 4.0.x
@meeseeksdev please backport to 3.6.x

@krassowski krassowski modified the milestones: 4.0.x, 3.6.x Apr 26, 2024
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 26, 2024
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 26, 2024
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 26, 2024
krassowski added a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
krassowski added a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
gderocher pushed a commit to gderocher/jupyterlab that referenced this pull request Apr 26, 2024
* Install Firefox from brew on Mac

* Try with pango and cairo from brew
krassowski added a commit that referenced this pull request Jun 19, 2024
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests on CI on MacOS are failing due to GitHub runners switching to arm64
2 participants