Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider higher levels when toggling plugin #16251

Merged

Conversation

divyansshhh
Copy link
Contributor

@divyansshhh divyansshhh commented Apr 26, 2024

Fixes #16101

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@divyansshhh
Copy link
Contributor Author

This was the initial commit made for #16102 (commit link).

I think I missed redoing this change while I was adding the _is_locked checks.

@krassowski can we release another patch with this since this is a blocking change for us? Apologies for the inconvenience.

@krassowski krassowski added the bug label Apr 26, 2024
@krassowski
Copy link
Member

It looks like having a test sequence in the usage test would help here. Do you have time to add it?

@krassowski krassowski added this to the 4.1.x milestone Apr 26, 2024
@krassowski
Copy link
Member

can we release another patch with this since this is a blocking change for us?

I can wait a bit with releasing 4.2.0rc0 if that works for you. We try not to release too frequently unless there are critical or security bugfixes because users get annoyed by frequent notifications about updates being available. That said if we just released today maybe another bugfix release is not that bad as most users would not have upgraded yet.

@divyansshhh
Copy link
Contributor Author

divyansshhh commented Apr 26, 2024

I can wait a bit with releasing 4.2.0rc0 if that works for you

4.2 has a couple of changes we want to take time and test so we would want to do thorough testing at our end before we upgrade. A 4.1 patch would be quicker to test.

We try not to release too frequently unless there are critical or security bugfixes because users get annoyed by frequent notifications about updates being available.

Yeah I understand but it'd be helpful to release another patch today.

@divyansshhh
Copy link
Contributor Author

It looks like having a test sequence in the usage test would help here. Do you have time to add it?

Yes I'm adding this

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @divyansshhh!

@krassowski krassowski merged commit 9b58fda into jupyterlab:main Apr 26, 2024
80 of 81 checks passed
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Apr 26, 2024
krassowski pushed a commit that referenced this pull request Apr 26, 2024
Co-authored-by: Divyansh Choudhary <divyanshchoudhary99@gmail.com>
gderocher pushed a commit to gderocher/jupyterlab that referenced this pull request Apr 26, 2024
* Consider higher levels when toggling plugin

* Add usage tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An extension disabled at the sys-prefix level can't be enabled at the user level
2 participants