-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider higher levels when toggling plugin #16251
Consider higher levels when toggling plugin #16251
Conversation
Thanks for making a pull request to jupyterlab! |
This was the initial commit made for #16102 (commit link). I think I missed redoing this change while I was adding the _is_locked checks. @krassowski can we release another patch with this since this is a blocking change for us? Apologies for the inconvenience. |
It looks like having a test sequence in the usage test would help here. Do you have time to add it? |
I can wait a bit with releasing 4.2.0rc0 if that works for you. We try not to release too frequently unless there are critical or security bugfixes because users get annoyed by frequent notifications about updates being available. That said if we just released today maybe another bugfix release is not that bad as most users would not have upgraded yet. |
4.2 has a couple of changes we want to take time and test so we would want to do thorough testing at our end before we upgrade. A 4.1 patch would be quicker to test.
Yeah I understand but it'd be helpful to release another patch today. |
Yes I'm adding this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @divyansshhh!
@meeseeksdev please backport to 4.1.x |
Co-authored-by: Divyansh Choudhary <divyanshchoudhary99@gmail.com>
* Consider higher levels when toggling plugin * Add usage tests
Fixes #16101