Reactive toolbar: avoid simultaneous calls to _onResize() #16335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
jtpio
approved these changes
May 16, 2024
|
@meeseeksdev please backport to 4.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
May 17, 2024
…lls to _onResize()
krassowski
pushed a commit
that referenced
this pull request
May 19, 2024
…Resize() (#16338) Co-authored-by: Nicolas Brichet <32258950+brichet@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case where the
_onResize()method of thereactiveToolbarcan be called 2 times simultaneously.Follows up #15553
On the first load of a reactive toolbar, the
_onResize()method need to be called twice, to ensure the proper organization of the widgets. But the second call was not properly awaited before this PR.In parallel, if an item is added during the second call, the method can be invoked again and can run simultaneously, which result in conflicts in the items count and ordering (it doesn't seem to happen too often, though).
References
Should fix jupyter/notebook#7370
Code changes
Add an await on the optional second call of
_onResize()User-facing changes
None
Backwards-incompatible changes
None
cc @jtpio