Fix Shift + Tab contextual help inspector tooltip regression

galata/test/jupyterlab/inspector-tooltip.test.ts

@@ -0,0 +1,30 @@
+// Copyright (c) Jupyter Development Team.
+// Distributed under the terms of the Modified BSD License.
+
+import { expect, test } from '@jupyterlab/galata';
+
+const fileName = 'notebook.ipynb';
+const TOOLTIP_SELECTOR = '.jp-Tooltip';
+
+test.describe('Inspector (contextual help) tooltip', () => {
+  test.beforeEach(async ({ page }) => {
+    await page.notebook.createNew(fileName);
+  });
+
+  test('Should show up on Shift + Tab', async ({ page }) => {
+    await page.notebook.setCell(0, 'code', 'int');
+    await page.notebook.enterCellEditingMode(0);
+    // Ensure the cursor is at the end of the cell, after "int"
+    await page.keyboard.press('End');
+    // Ensure kernel is ready
+    await page.locator('text=| Idle').waitFor();
+    const tooltip = page.locator(TOOLTIP_SELECTOR);
+    // There should be no tooltip yet
+    await expect(tooltip).toHaveCount(0);
+    // Invoke the tooltip
+    await page.keyboard.press('Shift+Tab');
+    // There should be a tooltip now
+    await expect(tooltip).toHaveCount(1);
+    await expect(tooltip).toContainText('int');
+  });
+});

packages/codemirror/src/commands.ts

@@ -141,7 +141,7 @@ export namespace StateCommands {
     dispatch: (transaction: Transaction) => void;
   }): boolean {
     if (target.dom.closest(TOOLTIP_OPENER_SELECTOR)) {
-      return true;
+      return false;
     }
     return indentLess(target);
   }