Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align token usage for events #16397

Merged

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented May 30, 2024

References

Follow up question by @emrahyildiz

Code changes

Align token usage in events API calls.

User-facing changes

None

Backwards-incompatible changes

None

Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski
Copy link
Member

The CI failure is unrelated (#16404)

@krassowski krassowski merged commit 872f22d into jupyterlab:main May 31, 2024
83 of 86 checks passed
@krassowski
Copy link
Member

@meeseeksdev please backport to 4.0.x
@meeseeksdev please backport to 4.1.x
@meeseeksdev please backport to 4.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request May 31, 2024
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request May 31, 2024
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request May 31, 2024
krassowski pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
krassowski pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
@fcollonval fcollonval deleted the fix/align-token-for-ws-events branch May 31, 2024 12:17
krassowski pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: Frédéric Collonval <frederic.collonval@webscit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants