Add typings to the inline completer example #16421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to jupyterlab! |
krassowski
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Sorry, I was too quick at first pass. I think you wanted to make the changes in Inline Completer section but you made them in Code Completer section. I added suggestions on the modified lines of code but GitHub UI does not allow me to add suggestions lower down on the Inline Completer section
|
Ah yes good catch, it was one section below! Fixing that now. |
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
|
Thanks for the review! |
|
@meeseeksdev please backport to 4.2.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Jun 4, 2024
krassowski
pushed a commit
that referenced
this pull request
Jun 4, 2024
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add typings to the inline completer example: https://jupyterlab.readthedocs.io/en/latest/extension/extension_points.html#inline-completer
To make easier to copy and paste the example, and have the extension build directly.
Code changes
Documentation update.
User-facing changes
None
Backwards-incompatible changes
None