Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load theme as extension (continued) #2283

Merged
merged 23 commits into from May 25, 2017
Merged

Load theme as extension (continued) #2283

merged 23 commits into from May 25, 2017

Conversation

@blink1073
Copy link
Member

@blink1073 blink1073 commented May 25, 2017

Split out default-theme into theming and theme-light-extension and load it as an extension. Fixes #2165 and replaces #2169 and finishes #2205.

Copy link
Contributor

@ellisonbg ellisonbg left a comment

Just a few minor comments. Will wait for reply but probably ready for merging.

@@ -8,7 +8,7 @@
"dependencies": {
"@jupyterlab/codemirror": "^0.5.0",
"@jupyterlab/console": "^0.5.1",
"@jupyterlab/default-theme": "^0.5.1",
"@jupyterlab/theming": "^0.5.1",
Copy link
Contributor

@ellisonbg ellisonbg May 25, 2017

In my PR, I entirely removed the theming assets from the individual packages. The idea was to not hard code those assets into other packages but let the theme itself choose to include them or not. That would allow themes to include the default assets, or provide their own set of them.

Copy link
Contributor

@ellisonbg ellisonbg May 25, 2017

Opps missed that this is an example, ignore that comment. Examples definitely need to include the themeing.

@@ -36,19 +31,24 @@ body {
}


.p-Widget.p-mod-hidden {
display: none !important;
#jp-main-dock-panel {
Copy link
Contributor

@ellisonbg ellisonbg May 25, 2017

Did we mean for this stuff to be here?

@@ -38,8 +38,8 @@
}


.jp-SideBar .p-TabBar-content,
.jp-SideBar .p-TabBar-content {
.jp-SideBar.p-TabBar .p-TabBar-content,
Copy link
Contributor

@ellisonbg ellisonbg May 25, 2017

Why more specificity needed?

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented May 25, 2017

I am going to do a bunch of work on design stuff now, going to merge this and we can iterate more in further PRs if needed.

@ellisonbg ellisonbg merged commit fc5877c into jupyterlab:master May 25, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request May 30, 2017
@blink1073 blink1073 deleted the pr/2205 branch Jun 6, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants