Load theme as extension (continued) #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisonbg
requested changes
May 25, 2017
| @@ -8,7 +8,7 @@ | |||
| "dependencies": { | |||
| "@jupyterlab/codemirror": "^0.5.0", | |||
| "@jupyterlab/console": "^0.5.1", | |||
| "@jupyterlab/default-theme": "^0.5.1", | |||
| "@jupyterlab/theming": "^0.5.1", | |||
There was a problem hiding this comment.
In my PR, I entirely removed the theming assets from the individual packages. The idea was to not hard code those assets into other packages but let the theme itself choose to include them or not. That would allow themes to include the default assets, or provide their own set of them.
There was a problem hiding this comment.
Opps missed that this is an example, ignore that comment. Examples definitely need to include the themeing.
| @@ -36,19 +31,24 @@ body { | |||
| } | |||
|
|
|||
|
|
|||
| .p-Widget.p-mod-hidden { | |||
| display: none !important; | |||
| #jp-main-dock-panel { | |||
There was a problem hiding this comment.
Did we mean for this stuff to be here?
| @@ -38,8 +38,8 @@ | |||
| } | |||
|
|
|||
|
|
|||
| .jp-SideBar .p-TabBar-content, | |||
| .jp-SideBar .p-TabBar-content { | |||
| .jp-SideBar.p-TabBar .p-TabBar-content, | |||
There was a problem hiding this comment.
Why more specificity needed?
ellisonbg
approved these changes
May 25, 2017
|
I am going to do a bunch of work on design stuff now, going to merge this and we can iterate more in further PRs if needed. |
Closed
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out
default-themeintothemingandtheme-light-extensionand load it as an extension. Fixes #2165 and replaces #2169 and finishes #2205.