Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design work on collapser and cells for the beta #3408

Merged
merged 3 commits into from Dec 19, 2017

Conversation

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Dec 18, 2017

  • Removes some stale styling of collapser
  • Styles collapser in console
  • Fixed console styles
  • Minor design updates to new cell view
@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Dec 18, 2017

Looks like there is still a rendering problem with the collapser on firefox latest. Working on that now...

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Dec 18, 2017

OK, talked with @blink1073 and @afshin:

  • Moved away from changing the width of the collapser on hover, was too flickery. Now using a more traditional mostly flat button design (see screenshots below).
  • Narrowed width of collapser to 8px, using minor box shadow and color change on hover.
  • Using simpler console design.
  • Also starting to use 2px border radius on buttons.

This is ready for review.

Dark theme, active, but not hovered:

screen shot 2017-12-18 at 10 42 34 am

Dark theme, active, input collapser hovered to show minor drop shadow and color change:

screen shot 2017-12-18 at 10 42 42 am

Light theme, active, but not hovered:

screen shot 2017-12-18 at 10 42 49 am

Light theme, active, input collapser hovered to show minor drop shadow and color change:

screen shot 2017-12-18 at 10 42 55 am

@ellisonbg
Copy link
Contributor Author

@ellisonbg ellisonbg commented Dec 18, 2017

And here is the console design:

screen shot 2017-12-18 at 10 48 49 am

Dark theme:

screen shot 2017-12-18 at 10 49 26 am

@blink1073
Copy link
Member

@blink1073 blink1073 commented Dec 19, 2017

Thanks!

@blink1073 blink1073 merged commit 8ff7d10 into jupyterlab:master Dec 19, 2017
2 checks passed
@blink1073 blink1073 mentioned this pull request Dec 23, 2017
1 task
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants