Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile returning a promise to a debouncer. #3622

Merged
merged 2 commits into from Jan 12, 2018
Merged

Reconcile returning a promise to a debouncer. #3622

merged 2 commits into from Jan 12, 2018

Conversation

afshin
Copy link
Member

@afshin afshin commented Jan 12, 2018 •
edited

Reconcile returning a promise to a debouncer by keeping track of outstanding promises and resolving/rejecting them.

This is necessary for the workspace save command so that it does not abandon promises from earlier requests to save a workspace.

@afshin
Reconcile returning a promise to a debouncer by keeping track of all …
78e0a7c 
…outstanding promises and resolving/rejecting them.
@afshin afshin added this to the Beta 2 milestone Jan 12, 2018
@afshin afshin self-assigned this Jan 12, 2018
@blink1073
Copy link
Member

Thanks!

@blink1073 blink1073 merged commit 41203c9 into jupyterlab:master Jan 12, 2018
@blink1073
Copy link
Member

@messeeksdev backport to 0.31.x

@blink1073 blink1073 deleted the restore-fix branch January 12, 2018 11:14
@blink1073 blink1073 restored the restore-fix branch January 12, 2018 11:14
@blink1073
Copy link
Member

@meeseeksdev backport to 0.31.x

lumberbot-app bot pushed a commit that referenced this pull request Jan 12, 2018
@afshin
Backport PR #3622: Reconcile returning a promise to a debouncer.
777bc15
@lumberbot-app lumberbot-app bot mentioned this pull request Jan 12, 2018
Closed
@blink1073 blink1073 deleted the restore-fix branch January 12, 2018 11:14
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@afshin afshin

Labels
bug pkg:apputils status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afshin @blink1073