Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile returning a promise to a debouncer. #3622

Merged
merged 2 commits into from Jan 12, 2018

Conversation

Projects
None yet
2 participants
@afshin
Copy link
Member

commented Jan 12, 2018

Reconcile returning a promise to a debouncer by keeping track of outstanding promises and resolving/rejecting them.

This is necessary for the workspace save command so that it does not abandon promises from earlier requests to save a workspace.

Reconcile returning a promise to a debouncer by keeping track of all …
…outstanding promises and resolving/rejecting them.

@afshin afshin added this to the Beta 2 milestone Jan 12, 2018

@afshin afshin self-assigned this Jan 12, 2018

@afshin afshin force-pushed the afshin:restore-fix branch from 289d8b9 to 2890119 Jan 12, 2018

@blink1073

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

Thanks!

@blink1073 blink1073 merged commit 41203c9 into jupyterlab:master Jan 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@blink1073

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

@messeeksdev backport to 0.31.x

@blink1073 blink1073 deleted the afshin:restore-fix branch Jan 12, 2018

@blink1073 blink1073 restored the afshin:restore-fix branch Jan 12, 2018

@blink1073

This comment has been minimized.

Copy link
Member

commented Jan 12, 2018

@meeseeksdev backport to 0.31.x

meeseeksdev bot pushed a commit that referenced this pull request Jan 12, 2018

@blink1073 blink1073 deleted the afshin:restore-fix branch Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.