Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wordWrapColumn and bounded line wrapping modes. #4936

Merged
merged 2 commits into from
Jul 23, 2018

Conversation

AlbertHilb
Copy link
Contributor

@AlbertHilb AlbertHilb commented Jul 20, 2018

Currently, in text editors, you can choose to not break line or to break line at viewport border.
I think it would be useful to have also the possibility to break line at a given column or at the minimum between the given column and the viewport width.

This PR adds a new property, wordWrapColumn, to the editorConfigsection of jupyterlab settings and changes lineWrap setting to accept one of the following string values:

  • off: lines never wrap,
  • on: lines wrap at viewport border,
  • wordWrapColumn: lines wrap at column specified by wordWrapColumn parameter,
  • bounded: lines wrap at minimum between viewport width and wordWrapColumn parameter.

This is the same setting schema used by VSCode.

Cheers

@AlbertHilb AlbertHilb changed the title Add wordWrapColumn and bounded line wrapping mode. Add wordWrapColumn and bounded line wrapping modes. Jul 20, 2018
settings and changes `linewarp` setting to accept one of the following
string values: `off`, `on`, `wordWrapColumn`, `bounded`.
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I don't have a computer for the next few days to try it locally, so I'll leave this open for now.

@blink1073
Copy link
Member

Thanks again!

@blink1073 blink1073 merged commit 81133a1 into jupyterlab:master Jul 23, 2018
@AlbertHilb AlbertHilb deleted the Softwrap branch July 23, 2018 09:38
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants