Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: terminal should default to configured monospace font #5732

Merged
merged 1 commit into from Dec 10, 2018
Merged

Fix regression: terminal should default to configured monospace font #5732

merged 1 commit into from Dec 10, 2018

Conversation

ashwinvis
Copy link
Member

And not courier

See earlier issue #1317, and PR #1377

Screenshots
Before:

screenshot_2018-12-06 jupyterlab

After:
screenshot_2018-12-06 jupyterlab_after

No settings:
screenshot_2018-12-06 jupyterlab_settings

@blink1073 blink1073 added this to the 1.0 milestone Dec 10, 2018
@blink1073
Copy link
Member

LGTM, thanks!

@blink1073 blink1073 merged commit 94c39e3 into jupyterlab:master Dec 10, 2018
@jiang-wenbin
Copy link

@ashwinvis @blink1073
Hi, I cann't find the settings for the terminal.
How can I enable it?

image

@ashwinvis
Copy link
Member Author

@jiang-wenbin it is not released yet, only available on the master version.... Soon 👍

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg:terminal status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashwinvis @blink1073 @jiang-wenbin