Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Spining to clockwise for jupyter lab build #7170

Merged
merged 1 commit into from
Sep 8, 2019
Merged

Changed Spining to clockwise for jupyter lab build #7170

merged 1 commit into from
Sep 8, 2019

Conversation

adityar-r
Copy link
Contributor

References

This request address this issue: #7169

Code changes

As mentioned in the issue, the line at jupyterlab/jupyterlab/commands.py
is changed from
spinner = itertools.cycle(['-', '/', '|', '\\'])
to
spinner = itertools.cycle(['-', '\\', '|', '/'])
This helps in displaying a clockwise animation during the issue of jupyter lab build command.

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

Thanks @bw-space, and congratulations on your first-time contribution!

@blink1073 blink1073 merged commit c027a58 into jupyterlab:master Sep 8, 2019
@blink1073 blink1073 added this to the 1.2 milestone Sep 8, 2019
@adityar-r
Copy link
Contributor Author

adityar-r commented Sep 8, 2019 via email

@blink1073
Copy link
Member

Cheers!

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants