Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort maintainers list in alphabetical order #7642

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

lresende
Copy link
Member

References

Sort maintainers list in alphabetical order as described in Team section.

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@afshin
Copy link
Member

afshin commented Dec 18, 2019

It looks like up until Vidar, we were originally sorted alphabetically by last name. Could we stick to that convention instead? I say this as the person whose first name and last name come first alphabetically 😉

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Member

Ah, I didn't see @afshin's comment, I agree.

@lresende
Copy link
Member Author

Good catch @afshin. I have updated with the proper order based on the last name.

Having said that, it feels a little strange that we sort based on the last name, but don't use a display like last name, name. Anyway, for now, is consistent with the label that says it's based on alphabetical order.

@blink1073 blink1073 merged commit 6b4e222 into jupyterlab:master Dec 18, 2019
@afshin
Copy link
Member

afshin commented Dec 18, 2019

Cheers!

@blink1073 blink1073 added this to the 2.0 milestone Jan 3, 2020
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants