New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle quit_button when launched as an extension #8486
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers!
👍
@meeseeksdev please backport to 1.2.x |
…6-on-1.2.x Backport PR #8486 on branch 1.2.x (Handle quit_button when launched as an extension)
@meeseeksdev please backport to 2.1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Handle quit_button when launched as an extension
References
Fixes #8483
Code changes
Moves handling of
quit_button
trait to the extension so it will be used when lab is launched as an extension.User-facing changes
Quit button logic works when running as
jupyter notebook
.Backwards-incompatible changes
None