Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI badges link to tests not svg #8603

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

mbuet2ner
Copy link
Contributor

References

Test badges schould link to tests not svg #8579.

Code changes

Update badges in README to have a similar behaviour like Spyder.

User-facing changes

Information on tests are now easier accessible (e.g. info on failed builds).

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@blink1073 blink1073 added this to the 2.2 milestone Jun 23, 2020
@blink1073 blink1073 merged commit 8fb048d into jupyterlab:master Jun 23, 2020
@blink1073
Copy link
Member

Congratulations on your first contribution to JupyterLab @mbuet2ner!

saulshanabrook pushed a commit that referenced this pull request Jun 25, 2020
CI badges link to tests not svg
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants