Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Tests in Sdist But Not Wheel #239

Merged
merged 5 commits into from Mar 15, 2022

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 13, 2022

This allows us to test on conda-forge with all of the tests, and use the layout recommended by pytest.

I'll follow this up with some CI cleanup.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@655d8e9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage        ?   68.47%           
=======================================
  Files           ?       19           
  Lines           ?     1567           
  Branches        ?        0           
=======================================
  Hits            ?     1073           
  Misses          ?      494           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655d8e9...ebf1d45. Read the comment docs.

@blink1073 blink1073 merged commit 819dce5 into jupyterlab:main Mar 15, 2022
@blink1073 blink1073 deleted the tests-in-sdist branch March 15, 2022 15:02
exclude = ['docs*']
exclude =
docs*
tests*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073 I think this is responsible for this error:

ImportError: Error importing plugin "jupyterlab_server.pytest_plugin": No module named 'jupyterlab_server.pytest_plugin'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll make a fix

@jtpio
Copy link
Member

jtpio commented Mar 17, 2022

Looks like this makes the JupyterLab tests fail with the latest jupyterlab_server? For example with the latest commit on master:

https://github.com/jupyterlab/jupyterlab/runs/5583340091?check_suite_focus=true

E   ModuleNotFoundError: No module named 'jupyterlab_server.tests'

@jtpio
Copy link
Member

jtpio commented Mar 17, 2022

Ah I see there is discussion about this starting from this comment: #243 (comment)

@davidbrochart
Copy link

I inlined expected_http_error() in jupyterlab/jupyterlab@404fe2e, as @blink1073 suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants