Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make private _drawCornerHeaderRegion protected drawCornerHeaderRegion #116

Merged
merged 1 commit into from Aug 24, 2020
Merged

Make private _drawCornerHeaderRegion protected drawCornerHeaderRegion #116

merged 1 commit into from Aug 24, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 21, 2020

Hi, my name is Logan McNichols. I am an intern for Jupyter Cal Poly. I am working on a tabular data editor powered by the DataGrid along with @kgoo124 and @ryuntalan.

This pull request would make the DataGrid's private method _drawCornerHeaderRegion a protected drawCornerHeaderRegion. It is helpful for extending classes to be able to access this method to repaint the 'corner-header' as the last paint operation.

Fixes #115

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073
Copy link
Member

I'm away from laptop until Monday

@blink1073 blink1073 merged commit 5ba3640 into jupyterlab:master Aug 24, 2020
@blink1073
Copy link
Member

Released as part of @lumino/datagrid: 0.13.0 => 0.14.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficult to keep corner header from getting painted on when painting on the column header.
2 participants