Optimise grid rendering #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
|
Thanks for making a pull request to lumino! |
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itay Dafna i.b.dafna@gmail.com
This PR introduces some rendering optimisations by enabling blitting where possible and reducing the number of paint calls for the entire viewport. There is still room for performance tuning, which I'll hopefully have time to explore in the next few weeks.
I also added a helper function
regionHasMergedCells. It's not used in this PR, but it will be used in the next PR.