Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): Add missing package.json dependencies #24

Merged
merged 1 commit into from Dec 10, 2019
Merged

chore(build): Add missing package.json dependencies #24

merged 1 commit into from Dec 10, 2019

Conversation

GordonSmith
Copy link
Contributor

Signed-off-by: Gordon Smith gordonjsmith@gmail.com

@afshin
Copy link
Member

afshin commented Dec 10, 2019

Hi @GordonSmith! Thanks for the PR.

Two things:

  1. Could you please add newlines at the end of each file? We use the Unix standard EOF, so each file ends with a newline.
  2. I'm not sure we want to switch to NPM instead of Yarn, but missing dependencies are missing dependencies, so thanks for fixing this!

afshin
afshin approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending adding newlines to the end of the modified files.

@GordonSmith
chore(build): Add missing package.json dependencies
009a78f 
Signed-off-by: Gordon Smith <gordonjsmith@gmail.com>
@GordonSmith
Copy link
Contributor Author

@afshin newlines added (auto formatting editor removed them)

@afshin afshin merged commit 09adfcf into jupyterlab:master Dec 10, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GordonSmith @afshin