fix(DockLayout): Invalid use of "this" in private namespace

[GordonSmith]

Signed-off-by: Gordon Smith GordonJSmith@gmail.com

[fcollonval]

Would it be better to be able to pass an optional document to realizeTabAreaConfig to be forward to createTabBar?

[GordonSmith]

Maybe - I am struggling to see where its used (as it doesn't seem to be hit in the tests and the old version of TypeScript isn't helpful).
I will have more time to dig into it in the morning, if your not looking for a quick fix today,

[GordonSmith]

@fcollonval: I changed the code as you suggested and did a bit more sanity checking...

Also I added TabPanel support to the web-components: https://gordonsmith.github.io/hpcc-js-wc/src/layouts/lumino/tabPanel.html

[fcollonval]

Thanks a lot for finalizing this one.

We should not change the signature of createTabBar as its part of the public API. Otherwise this is looking good.

[fcollonval]

We should keep it optional as this is part of the public API.

Suggested change

	createTabBar(document: Document | ShadowRoot): TabBar<Widget>;
	createTabBar(document?: Document | ShadowRoot): TabBar<Widget>;

[fcollonval]

We should keep it optional as this is part of the public API.

Suggested change

	createTabBar(document: Document | ShadowRoot): TabBar<Widget> {
	createTabBar(document?: Document | ShadowRoot): TabBar<Widget> {

[fcollonval]

LGTM thanks @GordonSmith

[blink1073]

Thanks! I'll cut a bugfix release now.

[fcollonval]

I'm sorry @GordonSmith I have a doubt due to this intermediate renderer definition. Actually, the this._document pass here is not use as these two callbacks are not passing through the received argument (and it does not make sense to allow a document other than this._document to be passed).
And as this is the only place Private.realizeAreaConfig is called, it sounds that your initial commit only removing this._document in Private.realizeTabAreaConfig is the only needed change, isn't it?

[GordonSmith]

I think its ok as they are just there to satisfy the IRenderer and resolve back onto itself (which is your point):

  private _createTabBar(): TabBar<Widget> {
    // Create the tab bar using the renderer.
    let tabBar = this.renderer.createTabBar(this._document);

...
  }

IOW changing to this:

          createTabBar: (document?: Document | SahdowRoot) => this._createTabBar(this._document),
          createHandle: () => this._createHandle()

Ends up exactly the same (again this is the point your making?)

You could argue that the following is better from a self-documenting point of view?

          createTabBar: (_document?: Document | SahdowRoot) => this._createTabBar(),
          createHandle: () => this._createHandle()

[fcollonval]

Thanks for the detailed answer. I agree with your latest proposal:

          createTabBar: (document?: Document | ShadowRoot) => this._createTabBar(),
          createHandle: () => this._createHandle()

It will indeed be a better self-documenting code. I opened #285 to add this.

[hbcarlos]

Thanks for the fix @GordonSmith!