Add collapse and expand methods to AccordionPanel
#321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind writing a little bit more about why this is a good feature to have, and what it enables? It is hard to quickly parse that from the Lab PR (it has a diff of +2,238 −2,776 lines). Also, I see this was added to the Lumino 2 milestone, but I do not think this is backwards incompatible? |
Done
Indeed this is compatible with the current version extending the API. |
afshin
reviewed
Aug 1, 2022
afshin
reviewed
Aug 1, 2022
afshin
reviewed
Aug 1, 2022
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/lumino
that referenced
this pull request
Aug 1, 2022
…ccordionPanel`
afshin
added a commit
that referenced
this pull request
Aug 1, 2022
…on-1.x Backport PR #321 on branch 1.x (Add `collapse` and `expand` methods to `AccordionPanel`)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
Required for jupyterlab/jupyterlab#12866
Code Changes
Add API to programmatically expand or collapse a
AccordionPanelwidget. Before only user by clicking on the title could do that.It is required for the extensions manager so we can show or hide the warning about installing third-party extensions depending on a settings parameter.