Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more safety workflows #350

Merged
merged 10 commits into from Aug 16, 2022
Merged

Add more safety workflows #350

merged 10 commits into from Aug 16, 2022

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Aug 16, 2022 •
edited

Workflows added:

  • PR auto author assignment
  • Check API changes - if the changes are valid, the PR author will need to explicitly update the files
  • CodeQL analysis
  • License header
  • Lock resolved threads

I decided to ignore the only CodeQL error: https://github.com/jupyterlab/lumino/security/code-scanning/1

First commit is expected to fail as the extracted API is not up-to-date.

@fcollonval fcollonval added this to the Lumino 2 milestone Aug 16, 2022
@fcollonval fcollonval added the maintenance Dependencies, build, technical debt, etc. label Aug 16, 2022
@fcollonval fcollonval marked this pull request as ready for review August 16, 2022 12:39
blink1073
blink1073 approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 3c24554 into jupyterlab:main Aug 16, 2022
@fcollonval fcollonval deleted the maintenance/more-gh-workflows branch August 16, 2022 14:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fcollonval @blink1073