Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate each<T>(...) #376

Merged
merged 2 commits into from Aug 25, 2022
Merged

Deprecate each<T>(...) #376

merged 2 commits into from Aug 25, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Aug 24, 2022 •
edited by fcollonval

This PR deprecates each<T>(...), removes all uses of it in tests and in the packages (except for the implementation and its tests), and updates the migration guide.

Fixes #375

@afshin afshin added documentation Improvements or additions to documentation maintenance Dependencies, build, technical debt, etc. labels Aug 24, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 24, 2022
@afshin afshin self-assigned this Aug 24, 2022
fcollonval
fcollonval requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one documentation suggestion and we are good to go.

docs/source/migration.md Outdated Show resolved Hide resolved
@afshin @fcollonval
Update docs/source/migration.md
a393a0b 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
fcollonval
fcollonval approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit 3f3d877 into jupyterlab:main Aug 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@afshin afshin

Labels
documentation Improvements or additions to documentation maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.

Deprecate each<T>(...)
2 participants
@afshin @fcollonval