Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Internet Explorer from tests, add Webkit #416

Merged
merged 5 commits into from Sep 27, 2022

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Sep 16, 2022

Closes #349.

@gabalafou
Copy link
Contributor Author

This doesn't work on my machine, even though I have a Mac.

When I try to run yarn test:webkit, I get the following console output:

$ cd tests && karma start --browsers=Webkit

START:
15 09 2022 19:59:51.320:WARN [filelist]: Pattern "/Users/gabriel/dev/lumino/packages/algorithm/tests/lib/bundle.test.js" does not match any file.
15 09 2022 19:59:51.335:INFO [karma-server]: Karma v6.4.0 server started at http://localhost:9876/
15 09 2022 19:59:51.335:INFO [launcher]: Launching browsers Webkit with concurrency unlimited
15 09 2022 19:59:51.340:INFO [launcher]: Starting browser Webkit
15 09 2022 19:59:51.342:ERROR [launcher]: No binary for Webkit browser on your platform.
  Please, set "WEBKIT_BIN" env variable.

@fcollonval
Copy link
Member

I suggest to switch to playwright as browser provider: see https://maksimrv.medium.com/unit-testing-javascript-with-karma-playwright-puppeteer-1d54139d422

That will help setting up test environment.

@gabalafou gabalafou marked this pull request as ready for review September 26, 2022 23:23
@gabalafou
Copy link
Contributor Author

@fcollonval, like this? My last commit adds Playwright as a dependency to all of the packages that have Karma tests.

On my machine, I was able to run yarn test:webkit from the root and all of the tests pass now.

@blink1073 blink1073 added the maintenance Dependencies, build, technical debt, etc. label Sep 26, 2022
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 90d68cd into jupyterlab:main Sep 27, 2022
@gabalafou gabalafou deleted the test-webkit-not-ie branch September 27, 2022 16:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove test scripts for IE, replace with WebKit
3 participants