Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DockLayout tests #421

Merged
merged 3 commits into from Oct 5, 2022
Merged

Add DockLayout tests #421

merged 3 commits into from Oct 5, 2022

Conversation

3coins
Copy link
Contributor

@3coins 3coins commented Sep 22, 2022

Fixes #410

@welcome
Copy link

welcome bot commented Sep 22, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 22, 2022
View reviewed changes
packages/widgets/tests/src/docklayout.spec.ts
it("should switch to 'display'", () => {
widgets[0].hiddenMode = Widget.HiddenMode.Scale;

layout.hiddenMode = Widget.HiddenMode.Scale;

Check warning

Code scanning / CodeQL

Useless assignment to property

This write to property 'hiddenMode' is useless, since [another property write](1) always overrides it.
@3coins 3coins added the maintenance Dependencies, build, technical debt, etc. label Sep 25, 2022
@3coins 3coins marked this pull request as ready for review September 28, 2022 13:57
@afshin afshin changed the title Added DockLayout tests Add DockLayout tests Sep 29, 2022
fcollonval
fcollonval requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @3coins

I have a minor suggestion but the rest looks good.

packages/widgets/tests/src/docklayout.spec.ts Outdated Show resolved Hide resolved
@3coins @fcollonval
Update packages/widgets/tests/src/docklayout.spec.ts
3261360 
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
fcollonval
fcollonval approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this one @3coins

@fcollonval fcollonval merged commit 5faf82f into jupyterlab:main Oct 5, 2022
@welcome
Copy link

welcome bot commented Oct 5, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@3coins 3coins

Labels
maintenance Dependencies, build, technical debt, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write more tests for DockPanel
2 participants
@3coins @fcollonval