Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When rejecting the internal promise in a Stream, catch failures #464

Merged
merged 1 commit into from Nov 14, 2022
Merged

When rejecting the internal promise in a Stream, catch failures #464

merged 1 commit into from Nov 14, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Nov 12, 2022

This is a minor bug that might manifest in testing suites or in circumstances where a Stream instance is stopped when nobody is subscribed to its async iterator.

@afshin afshin added the bug Something isn't working label Nov 12, 2022
@afshin afshin added this to the Lumino 2 milestone Nov 12, 2022
@afshin afshin marked this pull request as ready for review November 12, 2022 21:54
fcollonval
fcollonval approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit 9daf0a6 into jupyterlab:main Nov 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@afshin afshin

Labels
bug Something isn't working
Projects
None yet
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@afshin @fcollonval