Add contain strict for elements with fully managed layout #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coordinates and dimensions (top/left/width/height or top/left/bottom/right)
krassowski
added
enhancement
fcollonval
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #504
Uses strict CSS containment on elements with fully managed layout (absolutely positioned elements that specify all coordinates and dimensions, e.g. top + left + width + height, or top + left + bottom + right) to reduce layout cost (improves performance for resizing certain elements and other actions).
This requires that nothing within the widgets paints outside of it. Some modest changes may be needed downstream to remove painting outside of the widget box, as in jupyterlab/jupyterlab#13671.
The added contain can be overridden in sub-classes of
LayoutItem.I would suggest that we merge this, cut a release, pull it in JupyterLab and run full test suite (once jupyterlab/jupyterlab#13671 is in) to see if it causes any side-effects (I did not notice any in manual testing).
I would suggest that we do not backport this to 1.x and instead include a tailored solution in JupyterLab (I will prepare a PR).