Make the Application fully composable
#705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
May 28, 2024
| @@ -39,7 +39,7 @@ export { type IPlugin }; | |||
| * UI applications with the ability to be safely extended by third | |||
| * party code via plugins. | |||
| */ | |||
| export class Application<T extends Widget = Widget> { | |||
| export class Application<T extends Widget | HTMLElement = Widget> { | |||
There was a problem hiding this comment.
Maybe it could be useful to detail the benefit for providing an HTMLElement directly, instead of creating a new Widget() with its node option?
There was a problem hiding this comment.
Thanks for the review @jtpio
I updated the PR description. Does it answer your question?
fcollonval
force-pushed
the
ft/htmlelement-for-shell
branch
from
5c89d1f
to
d722a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the extraction of the plugin logic #703 to make the
Applicationfully composable.It also reduces the constrain on the shell to be a raw html element. The reason to remove the
Widgetconstrains is to allow other frameworks to be used with the Lumino Application without using the widgets framework (as the context menu can be switched to a custom one).