Have the DataGrid syncViewport when receiving a DataModel.ChangedArgs signal of type "rows-moved" or "columns-moved" #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m this._repaintOverlay(); to this._syncViewport();. Changed the commented lines above these commands to reflect the change
|
Thank you! |
|
Published as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my name is Logan McNichols. I am an intern for Jupyter Cal Poly, working with @kgoo124 and @ryuntalan to develop a tabular data editor powered by the DataGrid.
We noticed that submitting a
'rows-moved'or'columns-moved'signal to theDataGriddoes not seem to update it visually. I believe this is because, unlike the methods which handle adding or removing rows or columns, the methods_onRowsMovedand_onColumnsMoveddo not call_syncViewport().This pull request would replace
_onRowsMovedand_onColumnsMovedcall to_repaintOverlaywith a call to_syncViewport. It would also update the comments above these lines of code to reflect the change.Fixes #93