Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downstream tests are using the wrong pytest config #74

Closed
blink1073 opened this issue Mar 29, 2022 · 0 comments · Fixed by #75
Closed

Downstream tests are using the wrong pytest config #74

blink1073 opened this issue Mar 29, 2022 · 0 comments · Fixed by #75
Labels
bug Something isn't working

Comments

@blink1073
Copy link
Member

Description

The runs are picking up the pytest config of the host package.

cf https://github.com/jupyter/jupyter_client/runs/5740132235?check_suite_focus=true

rootdir: /home/runner/work/jupyter_client/jupyter_client, configfile: pyproject.toml

We should make sure that the test takes place in a directory that does not share a root directory with the host package.
@blink1073 blink1073 added the bug Something isn't working label Mar 29, 2022
This was referenced Mar 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a different directory for downstream tests blink1073/maintainer-tools
1 participant
@blink1073