Handle Warnings #760
Handle Warnings #760
Conversation
|
Downstream test failure is due to jupyterlab/maintainer-tools#74 |
There was a problem hiding this comment.
This looks good Steve - really nice to have such clean CI results!
Looking at the original attempts in #751, would it be possible to sneak in this particular change? I've run into this during race-condition testing on shutdown and it makes sense to silence the exception on shutdown that otherwise should be raised.
Good call, done! |
| @@ -11,14 +11,14 @@ | |||
| def run_sync(coro): | |||
| def wrapped(*args, **kwargs): | |||
| try: | |||
| loop = asyncio.get_event_loop() | |||
| loop = asyncio.get_running_loop() | |||
There was a problem hiding this comment.
This and only this line seem to be breaking some projects.
in particular https://github.com/Carreau/inplace_restarter.
It seem to be because asyncio.get_event_loop() can return the current event loop even if it's not (yet) running.
I'm not sure what a proper fix coulc be.
There was a problem hiding this comment.
Thanks for the heads up, I put a workaround in 0a2c228 (#772)
There was a problem hiding this comment.
Thanks , I also fixed my project upstream, I'll try to have a look at #772
Reboot of #751 without any changes to the
KernelManager.