Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PR Script Workflow #1

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Add a PR Script Workflow #1

merged 1 commit into from
Nov 17, 2021

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 17, 2021

Adds a workflow to run a script against a PR as a maintainer. The workflow is meant to be run from a fork using the maintainer's own GitHub credentials.

@blink1073 blink1073 added the enhancement New feature or request label Nov 17, 2021
@welcome
Copy link

welcome bot commented Nov 17, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@jtpio
Copy link
Member

jtpio commented Nov 17, 2021

Thanks!

@jtpio
Copy link
Member

jtpio commented Nov 17, 2021

Similar to this we could also have a workflow that takes an arbitrary command and opens a new PR with the changes (could be under the maintainer GitHub name).

For example this would be useful to update dependencies with commands like jlpm run update:dependency --regex @lumino/ latest

@welcome
Copy link

welcome bot commented Nov 17, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073 blink1073 deleted the pr-script branch November 17, 2021 15:54
@blink1073
Copy link
Member Author

I opened #5 to track that idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants