Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore links to GitHub user and organisation profiles #221

Closed

Conversation

krassowski
Copy link
Member

Ignores links to GitHub user and organisation profiles (but not repositories or other pages withing GH users/organizations).

Follows discussion in jupyterlab/jupyterlab#15776

@krassowski
Copy link
Member Author

I believe the downstream failures are unrelated. Is it ok to merge and release?

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@linlol
Copy link

linlol commented Mar 9, 2024

hi, would we merge it to resolve check-link failure?

Sorry for double confirming since it is still recurrently failing

@krassowski
Copy link
Member Author

I opened jupyterlab/jupyterlab#15959 which will allow us to merge this into jupyterlab directly.

@krassowski krassowski closed this Mar 11, 2024
@krassowski krassowski reopened this May 24, 2024
@krassowski
Copy link
Member Author

It looks it was done in #226.

@krassowski krassowski closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants