Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 and mypy linting #46

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Conversation

blink1073
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #46 (76601b2) into master (2190017) will decrease coverage by 0.31%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
- Coverage   90.72%   90.41%   -0.32%     
==========================================
  Files           5        5              
  Lines         291      292       +1     
==========================================
  Hits          264      264              
- Misses         27       28       +1     
Impacted Files Coverage Δ
pytest_check_links/plugin.py 92.46% <62.50%> (-0.37%) ⬇️
pytest_check_links/__init__.py 100.00% <100.00%> (ø)
pytest_check_links/args.py 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2190017...76601b2. Read the comment docs.

@blink1073 blink1073 requested a review from bollwyvl April 6, 2022 22:36
@blink1073
Copy link
Member Author

I'll cut a new release once this goes in.

Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 merged commit 3468259 into jupyterlab:master Apr 7, 2022
@blink1073 blink1073 deleted the flake8 branch April 7, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants