Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add team-compass page including JupyterLab Council members #139

Merged
merged 18 commits into from Jul 4, 2022
Merged

Conversation

afshin
Copy link
Member

@afshin afshin commented Mar 10, 2022

I copied @Zsailer's lead in setting up the Jupyter Notebook page. However, there are a few notable differences and I would really appreciate reviews on this:

  • I have changed the term "team" in a lot of places to JupyterLab Council to reflect the difference between the broader team and the decision-making body.
  • I have updated the steps outlined to becoming a new member of the JupyterLab Council to reflect the private nature of voting on individual members and to allow members to refuse membership. However I don't want to have unilaterally set the course of our decision-making. Please feel free to comment on this section and make suggestions.
  • I don't know what I am doing with regard to publishing to RTD. I think I did this correctly but I am not 100% confident of that.
  • @damianavila @marthacryan @ellisonbg @jasongrout @ivanov @krassowski @fperez @isabela-pf @jtpio You are all mentioned by name in this PR. Please take a look 馃憖

@jupyterlab jupyterlab deleted a comment from welcome bot Mar 10, 2022
@echarles
Copy link
Member

@afshin I may miss context. How is the list of contributors related to commit rights?

@afshin
Copy link
Member Author

afshin commented Mar 10, 2022

@echarles I think the file name is legacy from where I copied it, but there isn't a strict relationship between commit rights and membership in the JupyterLab Council. At some point when the Council is fully set up it might be a 1:1 relationship but for the process of ramping up, there will likely be many more people with commit rights than there are members of the JupyterLab Council.

@afshin
Copy link
Member Author

afshin commented Mar 10, 2022

Just to be clearer: that file in this PR is not the list of contributors for JupyterLab by any stretch 馃槀

docs/team.md Outdated Show resolved Hide resolved
docs/team.md Outdated Show resolved Hide resolved
@@ -0,0 +1,105 @@
(membership_guidelines)=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of mentions of "team" in this file that should be changed to "council". Also, it would be great to change the directory of these files from "team" to "council" if these are all about the council.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a few mentions of "team" that should mean the wider community of people. And there are some places where "team member" should just be "member". But I do think we should retain some usage of the term "team" because this is, after all, the team-compass.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I do think we should retain some usage of the term "team" because this is, after all, the team-compass.

Yes, absolutely!

afshin and others added 7 commits March 10, 2022 18:49
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
afshin and others added 2 commits March 10, 2022 20:12
Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
Co-authored-by: Isabela Presedo-Floyd <50221806+isabela-pf@users.noreply.github.com>
@jtpio
Copy link
Member

jtpio commented Jul 4, 2022

@afshin this is looking good, thanks for setting that up!

Do you think this is ready to be merged, so it can be iterated on as new members are added to the council?

@afshin
Copy link
Member Author

afshin commented Jul 4, 2022

@jtpio yeah, I think so. At first, I was hoping that we would synchronize with https://github.com/jupyter/team-compass-template but actually iterating seems better than leaving this open forever.

@afshin afshin marked this pull request as ready for review July 4, 2022 15:55
docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Jul 4, 2022

Just tried in a clean environment and although it gives a couple of warnings it seems to be building fine 馃憤

image

@jtpio
Copy link
Member

jtpio commented Jul 4, 2022

We could add the following to the .gitignore as well as they are generated at build time:

# docs generated files
_build
docs/team/active.txt
docs/team/inactive.txt

Otherwise it looks good and should be good to go!

@jtpio
Copy link
Member

jtpio commented Jul 4, 2022

We could add the following to the .gitignore as well as they are generated at build time:

Added in 151e0de.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's get that one in and iterate. Follow-up actions:

  • making sure the project exists on ReadTheDocs
  • enable the ReadTheDocs preview for pull requests

@afshin afshin merged commit 8ffc08a into master Jul 4, 2022
@welcome

This comment was marked as duplicate.

@jtpio jtpio deleted the rtd branch July 5, 2022 06:45
@jtpio
Copy link
Member

jtpio commented Jul 5, 2022

The site is now live on ReadTheDocs: https://jupyterlab-team-compass.readthedocs.io/en/latest/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants