New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to jupyterlab 3.1.0rc2 #283
Conversation
Looks like the
|
Plotly also failing:
|
|
While some demos are broken, I don't think it's worth blocking the merge on those, in this case... they probably just each need separate issues. |
mmm... the plotly fix... doesn't. still looking into it... |
Plotly fix appears to work locally... looking into altair... |
The altair fail is from overloading |
Thanks!! The fasta standalone file has been an issue for a while and could be tracked separately yet. However the renderer in the notebook should work (#284 and jupyterlab/jupyterlab#10675 for reference, not a blocker for this PR). |
We need to add the new jupyterlite/app/retro/index.template.js Line 51 in 9680e3e
I'll push a commit for this. |
Hmm looks like 28d31bc is not enough. Looking into doing the update in Retro first: jupyterlab/retrolab#186 |
Were those failures related to new versions of the libraries? |
Looks like both plotly and altair are back to working
Were those failures related to new versions of the libraries?
Nah, more transient deps. I assume people just hadn't been reviewing every
notebook every pr.
Due to mocking tornado, we have to mock... More tornado. Because plotly
might want to call home. Or something. Uses tenacity.
Altair was broken by overloading builtins.input with a pyodide.JsProxy.
this offended toolz.
|
The various above transient dep issues are part of why #45 is so important... four years later, all the jyve demos still work (to the extent that they every worked 馃ぃ). A full archival-grade workflow will eventually need to figure out how to capture everything it possibly can and put it together in the deployable folder/archive... this will require kernel-specific knowledge, of course, but i think we're getting there. Getting to investing in the JS kernels, we can likely figure out a prefetching strategy for es modules... i trust "hot" js packages probably the least in the whole stack. |
Fully agree 馃憤 Also just for the simple case of having everything easily working offline or in flight mode. |
I didna look at any of the RTC stuff... what are we expecting to have actually been fixed? |
Hoisted some observed errors to #286... not worth blocking here. |
That is weird, as this seems to be reproducible upstream (jupyterlab/jupyterlab#10675) |
best kind of 馃悰 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As mentioned above, let's track the outstanding issue in separate issues (some are already opened). |
References
Code changes
check
User-facing changes
Backwards-incompatible changes