Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Disable) Incompatible retro extensions? #286

Open
bollwyvl opened this issue Jul 22, 2021 · 7 comments
Open

(Disable) Incompatible retro extensions? #286

bollwyvl opened this issue Jul 22, 2021 · 7 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@bollwyvl
Copy link
Collaborator

Problem

  • jupyterlab-tour uses StateDB, which isn't available in (any?) of the retro pages
  • also jupyterlab-drawio doesn't work, apparently
These throw a bunch of scarrors: 
Plugin '@jupyterlab/drawio-extension:plugin' failed to activate.
(anonymous) @ index.es6.js:282
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.es6.js:283 Error: No provider for: @jupyterlab/filebrowser:IFileBrowserFactory.
    at f.e.resolveRequiredService (index.es6.js:197)
    at index.es6.js:155
    at Array.map ()
    at f.e.activatePlugin (index.es6.js:155)
    at index.es6.js:281
    at Array.map ()
    at f.e.start (index.es6.js:280)
    at index.js:250
(anonymous) @ index.es6.js:283
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.es6.js:282 Plugin 'jupyterlab-tour:plugin' failed to activate.
(anonymous) @ index.es6.js:282
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.es6.js:283 Error: No provider for: @jupyterlab/coreutils:IStateDB.
    at f.e.resolveRequiredService (index.es6.js:197)
    at index.es6.js:155
    at Array.map ()
    at f.e.activatePlugin (index.es6.js:155)
    at index.es6.js:281
    at Array.map ()
    at f.e.start (index.es6.js:280)
    at index.js:250
(anonymous) @ index.es6.js:283
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.es6.js:282 Plugin 'jupyterlab-tour:user-tours' failed to activate.
(anonymous) @ index.es6.js:282
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.es6.js:283 Error: No provider for: @jupyterlab/coreutils:IStateDB.
    at f.e.resolveRequiredService (index.es6.js:197)
    at index.es6.js:155
    at Array.map ()
    at f.e.activatePlugin (index.es6.js:155)
    at index.es6.js:281
    at Array.map ()
    at f.e.start (index.es6.js:280)
    at index.js:250
(anonymous) @ index.es6.js:283
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.es6.js:282 Plugin 'jupyterlab-tour:default-tours' failed to activate.
(anonymous) @ index.es6.js:282
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.es6.js:283 Error: No provider for: @jupyterlab/coreutils:IStateDB.
    at f.e.resolveRequiredService (index.es6.js:197)
    at index.es6.js:155
    at Array.map ()
    at f.e.activatePlugin (index.es6.js:155)
    at index.es6.js:281
    at Array.map ()
    at f.e.start (index.es6.js:280)
    at index.js:250
(anonymous) @ index.es6.js:283
Promise.catch (async)
(anonymous) @ index.es6.js:281
e.start @ index.es6.js:280
(anonymous) @ index.js:250
async function (async)
(anonymous) @ index.js:42
60880 @ index.js:256
v @ bootstrap:19
Promise.then (async)
(anonymous) @ bootstrap.js:90
async function (async)
(anonymous) @ bootstrap.js:75
37559 @ bootstrap.js:64
v @ bootstrap:19
(anonymous) @ startup:5
(anonymous) @ bundle.js:1
index.js:251 RetroLite started, waiting for restore
index.js:253 RetroLite restored
index.es6.js:211 TypeError: Cannot read property 'model' of undefined
    at actions.js:1261
    at b (index.es6.js:2309)
    at actions.js:1260
    at Function.e [as expandParent] (actions.js:1291)
    at index.js:1016
    at l (index.es6.js:459)
    at Object.n.emit (index.es6.js:416)
    at n.emit (index.es6.js:99)
    at ee.set activeCellIndex [as activeCellIndex] (widget.js:843)
    at ee.onCellRemoved (widget.js:1341)

which make it hard to find actual errors.

Proposed Solution

  • add tours and drawio to disabledExtensions in retro/jupyter-lite.json

Additional context
@bollwyvl bollwyvl added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 22, 2021
@bollwyvl bollwyvl mentioned this issue Jul 22, 2021
Merged
6 tasks
@jtpio
Copy link
Member

jtpio commented Jul 22, 2021

Thanks, disabling these extensions sounds good 👍

jupyterlab-tour uses StateDB, which isn't available in (any?) of the retro pages

We could also add StateDB to all retro pages so jupyterlab-tour doesn't fail to activate.

@bollwyvl
Copy link
Collaborator Author

If it works, it'd be nice!

@jtpio
Copy link
Member

jtpio commented Jul 22, 2021

Yeah we should be able to write tours for RetroLab that would be cool.

@bollwyvl
Copy link
Collaborator Author

so i see statedb in retro/package.json.... what's missing?

@jtpio
Copy link
Member

jtpio commented Jul 22, 2021

Probably we can just include the @jupyterlab/apputils-extension:state plugin from upstream:

https://github.com/jupyterlab/jupyterlab/blob/43c18c2818eb691120d8126e6eebd169f9683c20/packages/apputils-extension/src/index.ts#L368

This was referenced Jul 22, 2021
Closed
Merged
@jtpio
Copy link
Member

jtpio commented Jul 22, 2021

Opened #287 (not tested yet, but 🤞 )

@jtpio
Copy link
Member

jtpio commented Jul 22, 2021

Opened #287 (not tested yet, but crossed_fingers )

Looks like that one should be enough for tour.

For drawio, we could do the changes upstream so the extension doesn't fail to activate at least (tracked in QuantStack/jupyterlab-drawio#98)

@bollwyvl bollwyvl mentioned this issue Jul 23, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bollwyvl @jtpio